pkg/59878: net/ada-polyorb: don't evaluate variable in empty()

[rwhitlock22%gmail.com@localhost]

>Number:         59878
>Category:       pkg
>Synopsis:       net/ada-polyorb: don't evaluate variable in empty()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 02 06:55:00 +0000 2026
>Originator:     Robert Whitlock
>Release:        pkgsrc current, Dec 31, 2025
>Organization:
>Environment:
NetBSD 10.99.14
>Description:
Any invocation of the pkgsrc Makefile for net/ada-polyorb results in the following warning:

make: /usr/pkgsrc/net/ada-polyorb/Makefile:53: warning: Invalid character " " in variable name "event ir naming notification time"

and --with-corba-services=... not being set in CONFIGURE_ARGS. This appears to be because line 53

.if !empty(${CORBA_SERVICES})

shouldn't evaluate its argument, and instead it should be

.if !empty(CORBA_SERVICES)
>How-To-Repeat:
cd net/ada-polyorb
make show-var VARNAME=CORBA_SERVICES
>Fix:
--- Makefile.orig       2026-01-01 18:19:07.158050778 -0500
+++ Makefile    2026-01-02 01:41:10.950289563 -0500
@@ -2,6 +2,7 @@
 
 DISTNAME=      polyorb-${PKGVERSION_NOREV}
 PKGNAME=       polyorb-${GNAT_NAME}-25.0.0
+PKGREVISION=   1
 CATEGORIES=    net devel
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=AdaCore/}
 GITHUB_PROJECT=        PolyORB
@@ -50,7 +51,7 @@
 
 CONFIGURE_ARGS+=       --with-appli-perso=${APP_PERSONALITIES:Q}
 CONFIGURE_ARGS+=       --with-proto-perso=${PROTOCOL_PERSONALITIES:Q}
-.if !empty(${CORBA_SERVICES})
+.if !empty(CORBA_SERVICES)
 CONFIGURE_ARGS+=       --with-corba-services=${CORBA_SERVICES:Q}
 .endif
 EXTRA_GNATMAKE_FLAGS+= -eL -R -largs $${LDFLAGS} -margs