CVS commit: pkgsrc/multimedia/mp4v2

[Frédéric Fauberteau <triaxx%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   triaxx
Date:           Fri Jan  2 12:17:14 UTC 2026

Modified Files:
        pkgsrc/multimedia/mp4v2: Makefile distinfo
Added Files:
        pkgsrc/multimedia/mp4v2/patches: patch-src_mp4util.cpp

Log Message:
Fix abort with ctype(3) for NetBSD 11

https://github.com/TechSmith/mp4v2/pull/85


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 pkgsrc/multimedia/mp4v2/Makefile \
    pkgsrc/multimedia/mp4v2/distinfo
cvs rdiff -u -r0 -r1.1 pkgsrc/multimedia/mp4v2/patches/patch-src_mp4util.cpp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/multimedia/mp4v2/Makefile
diff -u pkgsrc/multimedia/mp4v2/Makefile:1.10 pkgsrc/multimedia/mp4v2/Makefile:1.11
--- pkgsrc/multimedia/mp4v2/Makefile:1.10       Fri Aug 26 06:40:25 2022
+++ pkgsrc/multimedia/mp4v2/Makefile    Fri Jan  2 12:17:14 2026
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.10 2022/08/26 06:40:25 adam Exp $
+# $NetBSD: Makefile,v 1.11 2026/01/02 12:17:14 triaxx Exp $
 
 DISTNAME=      mp4v2-5.0.1
+PKGREVISION=   1
 CATEGORIES=    multimedia
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=TechSmith/}
 GITHUB_TAG=    Release-ThirdParty-MP4v2-${PKGVERSION_NOREV}
@@ -12,7 +13,8 @@ LICENSE=      mpl-1.1
 
 WRKSRC=                ${WRKDIR}/mp4v2-${GITHUB_TAG}
 
-USE_LANGUAGES=         c c++11
+USE_LANGUAGES=         c c++
+USE_CXX_FEATURES=      c++11
 USE_LIBTOOL=           yes
 USE_PKGLOCALEDIR=      yes
 USE_TOOLS+=            gmake
Index: pkgsrc/multimedia/mp4v2/distinfo
diff -u pkgsrc/multimedia/mp4v2/distinfo:1.10 pkgsrc/multimedia/mp4v2/distinfo:1.11
--- pkgsrc/multimedia/mp4v2/distinfo:1.10       Fri Aug 26 06:40:25 2022
+++ pkgsrc/multimedia/mp4v2/distinfo    Fri Jan  2 12:17:14 2026
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.10 2022/08/26 06:40:25 adam Exp $
+$NetBSD: distinfo,v 1.11 2026/01/02 12:17:14 triaxx Exp $
 
 BLAKE2s (mp4v2-5.0.1.tar.gz) = e43bc4237475b3e573347e71b441900207b0dd04c81498d5cd9985366f9af6d7
 SHA512 (mp4v2-5.0.1.tar.gz) = 662b85e2d5cd1c190e7cbc7074914f750939694f8391ebf1402ecb90c533a35acc5bb5a1cfa852fc06e39c0b7e92142d26f8ee94fa2e6df2c0b1ed94fc2c63d7
@@ -7,6 +7,7 @@ SHA1 (patch-include_mp4v2_file.h) = bfb8
 SHA1 (patch-libutil_Utility.h) = 982a92307e50061cefb8b979382c227cae144358
 SHA1 (patch-src_mp4.cpp) = 53435290d3f3fd9ecc552357f674c54f5c6ec98d
 SHA1 (patch-src_mp4atom.cpp) = 78a6dce747a8c5cc73f231fa9b81d116b51cf4bb
+SHA1 (patch-src_mp4util.cpp) = 557fc51233462dd4b63f2f3178963c73e62f43e7
 SHA1 (patch-util_mp4art.cpp) = e14257a57bb297f158c1d2a9e39023535e558895
 SHA1 (patch-util_mp4chaps.cpp) = c22a9b8b086165d8e65aeb9f470d7c3eabb9adb6
 SHA1 (patch-util_mp4file.cpp) = 7e8ca0b042e96df1bc096f3efb351600432cdfd0

Added files:

Index: pkgsrc/multimedia/mp4v2/patches/patch-src_mp4util.cpp
diff -u /dev/null pkgsrc/multimedia/mp4v2/patches/patch-src_mp4util.cpp:1.1
--- /dev/null   Fri Jan  2 12:17:14 2026
+++ pkgsrc/multimedia/mp4v2/patches/patch-src_mp4util.cpp       Fri Jan  2 12:17:14 2026
@@ -0,0 +1,17 @@
+$NetBSD: patch-src_mp4util.cpp,v 1.1 2026/01/02 12:17:14 triaxx Exp $
+
+Fix abort with ctype(3) for NetBSD 11 (e.g. when s1 is "\251nam").
+
+https://github.com/TechSmith/mp4v2/pull/85
+
+--- src/mp4util.cpp.orig       2026-01-02 11:56:31.508036629 +0000
++++ src/mp4util.cpp
+@@ -40,7 +40,7 @@ bool MP4NameFirstMatches(const char* s1,
+         if (*s2 == '\0' || strchr("[.", *s2)) {
+             break;
+         }
+-        if (tolower(*s1) != tolower(*s2)) {
++        if (tolower((unsigned char)*s1) != tolower((unsigned char)*s2)) {
+             return false;
+         }
+         s1++;