pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: lang/quickjs update and shared lib enable



Hello Sergey,

Sergey A. Osokin writes:
> Hi,
> hope you're doing well.
>
> I have prepared a patch for lang/quickjs to:
> - update to the recent snapshot (a security fix has
>   been upstreamed)
> - enable build/install a shared library
>
> Could you please review and let me know your
> thoughts, comments, concerns.
> [...]

Thanks!

Is the shared library used by some other packages (also possible
pkgsrc-wip ones and/or something that we will package). It would be
nice to point that out. (It also has no version and that mean that
probably we need to always bump BUILDLINK_ABI_DEPENDS.)
Please also document the part of enabling the .so in the comment in
patch-Makefile.

Any idea about their release policy? In pkgsrc usually we avoid
non-release snapshot. It seems that all the security fixes are already
backported so updating it to a non-releasee snapshot is probably not
needed.  I would avoid that.


Looks good otherwise to me!


Home | Main Index | Thread Index | Old Index