Re: CVS commit: pkgsrc/graphics/py-Pillow

[Greg Troxel <gdt%lexort.com@localhost>]

"Ryo ONODERA" <ryoon%netbsd.org@localhost> writes:

> Index: pkgsrc/graphics/py-Pillow/Makefile
> diff -u pkgsrc/graphics/py-Pillow/Makefile:1.97 pkgsrc/graphics/py-Pillow/Makefile:1.98
> --- pkgsrc/graphics/py-Pillow/Makefile:1.97	Fri Jan  2 13:52:26 2026
> +++ pkgsrc/graphics/py-Pillow/Makefile	Wed Jan  7 14:26:55 2026
> @@ -1,4 +1,4 @@
> -# $NetBSD: Makefile,v 1.97 2026/01/02 13:52:26 adam Exp $
> +# $NetBSD: Makefile,v 1.98 2026/01/07 14:26:55 ryoon Exp $
>  
>  DISTNAME=	pillow-12.1.0
>  PKGNAME=	${PYPKGPREFIX}-${DISTNAME:S/^p/P/}
> @@ -27,6 +27,7 @@ DISTUTILS_BUILDDIR_IN_TEST_ENV=	yes
>  # as of 11.3.0
>  # 2 failed, 4934 passed, 88 skipped, 3 xfailed
>  
> +.include "../../lang/python/wheel.mk"
>  .include "../../devel/py-pybind11/buildlink3.mk"
>  .include "../../devel/zlib/buildlink3.mk"
>  .include "../../graphics/libavif/buildlink3.mk"
> @@ -37,6 +38,5 @@ DISTUTILS_BUILDDIR_IN_TEST_ENV=	yes
>  .include "../../graphics/openjpeg/buildlink3.mk"
>  .include "../../graphics/raqm/buildlink3.mk"
>  .include "../../graphics/tiff/buildlink3.mk"
> -.include "../../lang/python/wheel.mk"
>  .include "../../mk/jpeg.buildlink3.mk"
>  .include "../../mk/bsd.pkg.mk"

I'm not saying this is wrong, but

  - how does moving wheel.mk affect things?

  - if it does change behavior, how are people that read wheel.mk
    comments/instructions supposed to know what to do?

  - did pkglint flag this?  If not, could it?