tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/graphics/py-Pillow



Roland Illig <roland.illig%gmx.de@localhost> writes:

> Am 07.01.2026 um 18:31 schrieb Greg Troxel:
>> Ryo ONODERA <ryo%tetera.org@localhost> writes:
>> 
>>>> I'm not saying this is wrong, but
>>>>
>>>>   - how does moving wheel.mk affect things?
>>>
>>> My change is ugly workaround and it looks strange, of course.
>>> The root cause is inclusion of lang/python/pyversion.mk in
>>> devel/py-pybind11/buildlink3.mk.
>>> I think inclusion of lang/python/pyversion.mk may be removed from buildlink3.mk.
>>> However I am not sure yet.
>> 
>> Ah, so
>> 
>>    - maybe it's not wrong, and wheel.mk must be included before any
>>      py-foo bl3, in which case we should change the documentation.
>
> This could even be checked automatically in wheel.mk:
>
> .if !empty(BUILDLINK_TREE)
> # TODO: explain why this is the case.
> .  error "must be included before any buildlink3.mk file"
> .endif

If that is really true (in practice, even if not explainable), then
adding that and adding it to the documentation/comments explaining how
to use wheel,mk would be a good step forward.


Home | Main Index | Thread Index | Old Index